Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind left/right content mouse areas to enabled state by default #3328

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

tomasMizera
Copy link
Collaborator

Let's bind enabled property of left/right content mouse area to the editState === "enabled" so that we do not need to bind it individually in each input/editor

Copy link

Pull Request Test Coverage Report for Build 8724464818

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 60.073%

Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/app/projectsmodel.cpp 6 65.75%
Totals Coverage Status
Change from base Build 8721411687: 0.0%
Covered Lines: 7586
Relevant Lines: 12628

💛 - Coveralls

@PeterPetrik PeterPetrik merged commit 88eb2b6 into rework-base-input Apr 18, 2024
11 checks passed
@PeterPetrik PeterPetrik deleted the disable-mouseareas-base-input branch April 18, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants