Add a new option in the list of industries for Students/University #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10007946098Details
💛 - Coveralls |
tomasMizera
reviewed
Jul 19, 2024
tomasMizera
reviewed
Jul 19, 2024
VitorVieiraZ
requested changes
Jul 19, 2024
| @@ -46,24 +46,6 @@ Item { | |||
| stackView.pop(null); | |||
| } | |||
|
|
|||
| function shuffleAndAppend( listModel, items ) | |||
There was a problem hiding this comment.
We can keep shuffleAndAppend method exclusively in MMAccountController, as it will be inherited by both MMWhichIndustryPage and MMHowYouFoundUsPage. This way, there is no need to declare it twice.
There was a problem hiding this comment.
It was moved to make the "MerginMapsGallery" app working as the gallery don't inherit MMAccountController, afaik but maybe there is a more clever way to separate business logic with UI
VitorVieiraZ
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a "Student/University" option in the list of industries during the onboarding process on the app
To note: screenshot is not translated yet
This PR also fix the "gallery" app for "Account and Onboarding" > "Which industry"
close #3533