Fix missing promise catches in s2o cli

Mermade · Jan 25, 2018 · 72bd25b · 72bd25b
1 parent 8f4d5fb
commit 72bd25b
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -1344,7 +1344,8 @@ function convertStr(str, options, callback) {
         if (obj) {
             options.original = obj;
             convertObj(obj, options)
-            .then(options => resolve(options));
+            .then(options => resolve(options))
+            .catch(ex => reject(ex));
         }
         else {
             reject(new Error('Could not parse string'));
@@ -1365,7 +1366,8 @@ function convertUrl(url, options, callback) {
             return res.text();
         }).then(function (body) {
             convertStr(body, options)
-            .then(options => resolve(options));
+            .then(options => resolve(options))
+            .catch(ex => reject(ex));
         }).catch(function (err) {
             reject(err);
         });
@@ -1381,7 +1383,8 @@ function convertFile(filename, options, callback) {
             else {
                 options.sourceFile = filename;
                 convertStr(s, options)
-                .then(options => resolve(options));
+                .then(options => resolve(options))
+                .catch(ex => reject(ex));
             }
         });
     }));
@@ -1395,7 +1398,8 @@ function convertStream(readable, options, callback) {
         })
         .on('end', function () {
             convertStr(data, options)
-            .then(options => resolve(options));
+            .then(options => resolve(options))
+            .catch(ex => reject(ex));
         });
     }));
 }

diff --git a/test/missing-ref/openapi.yaml b/test/missing-ref/openapi.yaml
@@ -0,0 +1,10 @@
+openapi: 3.0.0
+info:
+  title: API
+  version: 1.0.0
+paths:
+  /:
+    get:
+      responses:
+        '200':
+          description: OK
diff --git a/test/missing-ref/options.yaml b/test/missing-ref/options.yaml
@@ -0,0 +1 @@
+warnOnly: true
diff --git a/test/missing-ref/swagger.yaml b/test/missing-ref/swagger.yaml
@@ -0,0 +1,12 @@
+swagger: 2.0
+info:
+  title: API
+  version: 1.0.0
+paths:
+  /:
+    get:
+      parameters:
+        - $ref: '#/parameters/notthere'
+      responses:
+        '200':
+          description: OK