Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meros connects to connected peers multiple times. #163

Closed
kayabaNerve opened this issue Mar 29, 2020 · 1 comment
Closed

Meros connects to connected peers multiple times. #163

kayabaNerve opened this issue Mar 29, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
Developer Testnet...

Comments

@kayabaNerve
Copy link
Member

This isn't critical as Meros detects they're duplicates after handshaking. That said, it is inefficient, and the fact they're connecting at all is exacerbating #158, which is critical.

The best solution is to abstract out the checks and accept that we'll call them multiple times.
@kayabaNerve kayabaNerve added the bug Something isn't working label Mar 29, 2020
kayabaNerve added a commit that referenced this issue Mar 30, 2020
@kayabaNerve
Replace all instances of asyncdispatch/asyncnet with chronos.
6683efd 
Adds chronos as a dependency.

DBDumpSample is left alone as the Meros RPC library still uses 
asyncdispatch/asyncnet. The plan isn't to update the Meros RPC lib in 
order to maintain flexibility with various Nim apps.

This branch specifically aims to fix #130, #141, #159, and #163 as part 
of the move to Chronos.
kayabaNerve added a commit that referenced this issue Mar 30, 2020
@kayabaNerve
Update the connection handling code.
6ea6c59 
Expects an abstracted verifyAddress call, as needed for 
#163.

Also uses a new thread/async-safe API and partially moves to chronos.

Also implements the lack of need for peek and offers much cleaner code.
@kayabaNerve
Copy link
Member Author

This is fixed in the chronos branch.

@kayabaNerve kayabaNerve mentioned this issue Apr 4, 2020
Merged
kayabaNerve added a commit that referenced this issue Apr 4, 2020
@kayabaNerve
Chronos (#168)
1964b32 
Replaces asyncnet with chronos.

Removes globals and gcsafe overrides, while adding gcsafe type requirements.

Fixes #130, #163, #159, and #141.

Also updates IP requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
Developer Testnet 4 Stable
Development

No branches or pull requests
1 participant
@kayabaNerve