Skip to content

Commit

Permalink
fix: make the working barrier on settings page dismissible
Browse files Browse the repository at this point in the history
Barrier is dismissible because the SettingsCubit.toggleAutostart() method
can fail for Flatpak, and for some reason we can't catch the error.

This way, the user can dismiss the barrier instead of being stuck.

Resolves #202
  • Loading branch information
Merrit committed Feb 21, 2024
1 parent 816870b commit 8281482
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion lib/settings/settings_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@ import 'settings.dart';
void _showLoadingDialog(BuildContext context) {
showDialog(
context: context,
barrierDismissible: false,
// Barrier is dismissible because the SettingsCubit.toggleAutostart() method
// can fail for Flatpak, and for some reason we can't catch the error.
//
// This way, the user can dismiss the barrier instead of being stuck.
//
// https://github.com/Merrit/nyrna/issues/202
barrierDismissible: true,
builder: (context) {
// If working is already false because it was a quick operation, we don't
// need to show the dialog.
Expand Down

0 comments on commit 8281482

Please sign in to comment.