Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sys: fixed random option uniqueid #289

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Sys: fixed random option uniqueid #289

merged 1 commit into from
Jul 5, 2022

Conversation

RocioRojas
Copy link
Contributor

Contribution description

Fixed a random option in module uniqueid using a seed cryptographically secure with NETOPT_RANDOM and added a function to uniqueid test.

Testing procedure

look at tests/uniqueid

use the command make menuconfig, click in uniqueid/subnet option and choose random and save.

In to the console write make flash test term

Issues/PRs references

Fixes #280, see also #279

@RocioRojas RocioRojas added this to the 0.22.12-RC1 milestone Jul 5, 2022
@RocioRojas RocioRojas added this to In Progress in Firmware via automation Jul 5, 2022
eduazocar
eduazocar requested changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@eduazocar eduazocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see good the solution, but' you could try importing radio module to get the interface

firmware/sys/uniqueid/uniqueid.c Show resolved Hide resolved
firmware/sys/uniqueid/Makefile.dep Outdated Show resolved Hide resolved
eduazocar
eduazocar approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@eduazocar eduazocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good for me :+1 go ahead

@RocioRojas RocioRojas merged commit eb1466b into Mesh4all:main Jul 5, 2022
Firmware automation moved this from In Progress to Done Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduazocar eduazocar eduazocar approved these changes

@luisan00 luisan00 Awaiting requested review from luisan00

Assignees
No one assigned
Labels
Area: doc Area: firmware Area: Kconfig Area: sys Area: tests
Projects
Firmware
  
Done
Milestone
0.22.12-RC1
Development

Successfully merging this pull request may close these issues.

Sys/Uniqueid: Make a seed cryptographically secure
2 participants
@RocioRojas @eduazocar