-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-write of docs/usage.md #184
Conversation
Closes #180 Re-writes the `docs/usage` page of the website with description and screenshots for using [mesnage-org.github.io/pgfinder-gui](https://mesnage-org.github.io/pgfinder-gui/).
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 71.02% 69.56% -1.47%
==========================================
Files 8 10 +2
Lines 535 552 +17
==========================================
+ Hits 380 384 +4
- Misses 155 168 +13 ☔ View full report in Codecov by Sentry. |
Do you have the equivalent document for the original myBinder? |
I made a few changes, nothing major though. No idea what I'm supposed to do but I'll press the commit changes button.
On a quick glance, this looks great! I'll take a closer look in the next few days! |
The current documentation has the JupyterLite version which really just replaced the screenshots so they aligned, see here. You can see a crude example of how it renders in HTML here which includes the text and in-line images.
Not a problem at all, its really useful to have your feedback.
Cool, no rush, just had some time where I need something relaitvely mindless to do so figured I'd go through, take some screenshots and have a go at re-writing the text. Feedback welcome. 😄 |
Still needs an even deeper look, but I don't know if any of the cache-clearing stuff is still valid. Pyodide doesn't actually seem to cache anything by default — I think that was JupyterLite playing intentionally with IndexedDB. I'm thinking about adding the cache back, but with an explicit check / hash of the pip package info so it's invalidated every time PGFinder is updated! |
Checked https://mesnage-org.github.io/pgfinder-gui/ from Firefox, Opera and Chromium
I found this thread which points to this article on WASM caching but my (crude) understanding is that caching WASM wouldn't be a problem.
That would be neat, although I think a more general solution would be if we could include the ability in |
Removed reference to clearing cache, if no other comments or tweaks this is ready to merge. |
I think it looks great! Only thing is that a couple of GUI tweaks in the
next few days might warrant new screenshots, but those can be a second PR
if you'd prefer!
…On Tue, 15 Aug 2023, 15:01 Neil Shephard, ***@***.***> wrote:
Removed reference to clearing cache, if no other comments or tweaks this
is ready to merge.
—
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPWK25D3W6TRHK5XCCPTGTXVN6MFANCNFSM6AAAAAA2XB5PLQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Great, I'll merge this, we can tweak in the future. Not a fan of PRs dragging out, counter to the idea that commits should be small. |
Closes #180
Re-writes the
docs/usage
page of the website with description and screenshots for using mesnage-org.github.io/pgfinder-gui.