Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write of docs/usage.md #184

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Re-write of docs/usage.md #184

merged 3 commits into from
Aug 16, 2023

Conversation

ns-rse
Copy link
Collaborator

@ns-rse ns-rse commented Jul 25, 2023

Closes #180

Re-writes the docs/usage page of the website with description and screenshots for using mesnage-org.github.io/pgfinder-gui.

Closes #180

Re-writes the `docs/usage` page of the website with description and screenshots for using
[mesnage-org.github.io/pgfinder-gui](https://mesnage-org.github.io/pgfinder-gui/).
@ns-rse ns-rse added the documentation Improvements or additions to documentation label Jul 25, 2023
@ns-rse ns-rse added this to the JOSS publication milestone Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.47% ⚠️

Comparison is base (8435a77) 71.02% compared to head (e97fccc) 69.56%.
Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   71.02%   69.56%   -1.47%     
==========================================
  Files           8       10       +2     
  Lines         535      552      +17     
==========================================
+ Hits          380      384       +4     
- Misses        155      168      +13     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smesnage
Copy link
Collaborator

Do you have the equivalent document for the original myBinder?
I can give it a shot once I know what you're after, especially how much details are needed.
Sorry you have to tell me everyting!

I made a few changes, nothing major though.
No idea what I'm supposed to do but I'll press the commit changes button.
@TheLostLambda
Copy link
Member

On a quick glance, this looks great! I'll take a closer look in the next few days!

@ns-rse
Copy link
Collaborator Author

ns-rse commented Jul 25, 2023

Do you have the equivalent document for the original myBinder?
I can give it a shot once I know what you're after, especially how much details are needed.

The current documentation has the JupyterLite version which really just replaced the screenshots so they aligned, see here.

You can see a crude example of how it renders in HTML here which includes the text and in-line images.

Sorry you have to tell me everything!

Not a problem at all, its really useful to have your feedback.

On a quick glance, this looks great! I'll take a closer look in the next few days!

Cool, no rush, just had some time where I need something relaitvely mindless to do so figured I'd go through, take some screenshots and have a go at re-writing the text. Feedback welcome. 😄

@TheLostLambda
Copy link
Member

Still needs an even deeper look, but I don't know if any of the cache-clearing stuff is still valid. Pyodide doesn't actually seem to cache anything by default — I think that was JupyterLite playing intentionally with IndexedDB. I'm thinking about adding the cache back, but with an explicit check / hash of the pip package info so it's invalidated every time PGFinder is updated!

@ns-rse
Copy link
Collaborator Author

ns-rse commented Jul 28, 2023

Still needs an even deeper look, but I don't know if any of the cache-clearing stuff is still valid. Pyodide doesn't actually seem to cache anything by default — I think that was JupyterLite playing intentionally with IndexedDB.

Checked https://mesnage-org.github.io/pgfinder-gui/ from Firefox, Opera and Chromium

  • Firefox says there isn't anything being stored by the site.
  • Opera not clear, but takes a while to load mass libraries and options suggesting they're not cached.
  • Chromium not clear, but again takes a while to load mass libraries and options suggesting they're not cached.

I found this thread which points to this article on WASM caching but my (crude) understanding is that caching WASM wouldn't be a problem.

I'm thinking about adding the cache back, but with an explicit check / hash of the pip package info so it's invalidated every time PGFinder is updated!

That would be neat, although I think a more general solution would be if we could include the ability in pgfinder-gui for users to select what version they run against if that is at all possible. An issue for a different repo perhaps, not sure if we should aim to include it prior to submission of JOSS (can always keep adding things!).

@ns-rse
Copy link
Collaborator Author

ns-rse commented Aug 15, 2023

Removed reference to clearing cache, if no other comments or tweaks this is ready to merge.

@TheLostLambda
Copy link
Member

TheLostLambda commented Aug 15, 2023 via email

@ns-rse
Copy link
Collaborator Author

ns-rse commented Aug 16, 2023

I think it looks great! Only thing is that a couple of GUI tweaks in the next few days might warrant new screenshots, but those can be a second PR if you'd prefer!

Great, I'll merge this, we can tweak in the future. Not a fan of PRs dragging out, counter to the idea that commits should be small.

@ns-rse ns-rse merged commit eb4b2d4 into master Aug 16, 2023
13 of 14 checks passed
@ns-rse ns-rse deleted the ns-rse/180-revise-usage.md branch August 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise docs/usage.md
3 participants