Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe inputBar frame change to update collectionView bottom inset #1726

Merged
merged 5 commits into from Jul 20, 2022

Conversation

martinpucik
Copy link
Contributor

What does this implement/fix? Explain your changes.

  • Rely on inputBar frame change rather than on keyboard notifications to update collectionView bottom inset
  • No need for currently presented modal checks

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Devices/Simulators:

iOS Version:

Swift Version:

MessageKit Version:

@martinpucik martinpucik marked this pull request as ready for review July 20, 2022 13:15
@martinpucik martinpucik enabled auto-merge (squash) July 20, 2022 13:21
@martinpucik martinpucik merged commit 6244308 into main Jul 20, 2022
@martinpucik martinpucik deleted the enh/observe-input-bar-frame branch July 20, 2022 14:26
Patrick-Kladek pushed a commit to medbee/MessageKit that referenced this pull request Oct 25, 2023
…essageKit#1726)

* feat: Update bottom inset on InputBar frame  change

* feat: Update bottom inset on InputBar frame  change

Delay textview did begin editing notification for scroll to bottom to work

* feat: Update bottom inset on InputBar frame  change

Remove unnecessary presentedController check

* feat: Update bottom inset on InputBar frame  change

Docu

* feat: Update bottom inset on InputBar frame  change

Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants