Add boolean flag to disable auto updating send button enabled state #530
Conversation
…on text did change
clayellis
changed the title
Sources/Views/MessageInputBar.swift
Outdated
| @@ -136,6 +136,9 @@ open class MessageInputBar: UIView { | |||
| $0.messageInputBar?.didSelectSendButton() | |||
| } | |||
| }() | |||
|
|
|||
| /// A boolean that determines if the sendButton's `isEnabled` state should be auto updated on text changes. | |||
| open var shouldAutoUpdateSendButtonEnabledStateOnTextDidChange = true | |||
There was a problem hiding this comment.
I'm cool with this 😎 Thanks for making the PR. Can we rename it shouldManageSendButtonEnabledState? Open to shorter suggestions 😂
We also need to add a CHANGELOG entry under Added
There was a problem hiding this comment.
I was just following the naming conventions I saw used elsewhere for the sake of being consistent. (Specifically shouldAutoUpdateMaxTextViewHeight). I'm up for being more concise as long as it's not at the expense of clarity! shouldManageSendButtonEnabledState is great. I'll update that and add a CHANGELOG entry.
…ManageSendButtonEnabledState and update documentation comment.
|
Thank you for reviewing this @MacMeDan ❤️ We aren't using the |
|
Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃 |
What does this implement/fix? Explain your changes.
Adds a boolean flag to disable auto updating send button enabled state on text did change.
Does this close any currently open issues?
#529
Any other comments?
This PR doesn't change any current default behavior. Use of the flag is completely optional.
Where has this been tested?
Devices/Simulators: Both
iOS Version: iOS 11.2
Swift Version: 4
MessageKit Version: 0.13.1