Swift 4.2 #883
Swift 4.2 #883
Conversation
There was a problem hiding this comment.
@nathantannar4 Please add a CHANGELOG entry for the upcoming release - "Added Swift 4.2 support"
| @@ -28,7 +28,7 @@ open class PlayButtonView: UIView { | |||
|
|
|||
| // MARK: - Properties | |||
|
|
|||
| open let triangleView = UIView() | |||
| public let triangleView = UIView() | |||
There was a problem hiding this comment.
Emm, how about make it open and var?
There was a problem hiding this comment.
What would be the use case for allowing someone to set a new value?
There was a problem hiding this comment.
Maybe users want to do some custom things? Make it open have no side-effect, right?
There was a problem hiding this comment.
Before it was open but a let. So technically they can't change it. But if it's changed to var someone can set it to something. But if they set it that won't automatically add the new view to the superview or lay it out.
|
This is awesome! Please update MessageInputBar as well :D |
|
Oh I see the repo is updated, but cocoapod didn't update it - probably because the podspec didn't specify a version. I had to add MessageInputBar directly in my pod file, then it was updated from 0.2.2 to 0.4.0 |
|
@nathantannar4 PodSpec invalid, MessageKit's InputBar automatically install 0.2.2 version instead of 0.4. |
|
@nathantannar4 You can release |
|
Sure, released just now |
What does this implement/fix? Explain your changes.
Updates the codebase to Swift 4.2, specifies Swift 4.2 version of
MessageInputBar, update CircleCi configDoes this close any currently open issues?
Everyone requesting Swift 4.2 馃槉
Any other comments?
Sorry to those who have submitted Swift 4.2 PRs already. #880 was branched from
master, notdevelopmentand we have already made changes indevelopmentFor those who want early access, use the branch
swift-4.2This will segue
MessageKitto its 1.1 release