Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UriFormatter should use Uri.OriginalString when serializing #1106

Merged
merged 1 commit into from
Nov 9, 2020
Merged

UriFormatter should use Uri.OriginalString when serializing #1106

merged 1 commit into from
Nov 9, 2020

Conversation

degant
Copy link
Contributor

@degant degant commented Nov 9, 2020 •
edited

Fixes #1105

  • Use Uri.OriginalString during serialization
  • Uri.OriginalString survives serialization roundtrip so using OriginalString in the tests

AArnott
AArnott approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AArnott AArnott merged commit 84564bf into MessagePack-CSharp:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UriFormatter should use Uri.OriginalString when serializing
2 participants
@degant @AArnott