Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union type collect #1634

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Conversation

Scormave
Copy link
Contributor

@Scormave Scormave commented Jun 2, 2023

If there is an interface declaration with Union attributes, types that are specified aren't collected for formatter generation. But, in the same time, if there is Union attributes above generic type declaration, types from them will be collected (CollectGenericUnion).

@Scormave Scormave changed the base branch from master to develop June 2, 2023 07:09
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Might I prevail upon you to add a test for this case?

@Scormave
Copy link
Contributor Author

@AArnott Yes, of course. Added test case.

@gsino
Copy link

gsino commented Jun 29, 2023

I previously submitted a pull request for a fix for the same issue.
#1322

@AArnott
Copy link
Collaborator

AArnott commented Aug 13, 2023

@gsino I'm sorry your PR didn't get traction earlier. Thanks for contributing though!

Thanks for the added test @Scormave!

@AArnott AArnott added this to the v2.6 milestone Aug 13, 2023
@AArnott AArnott merged commit f54d0cd into MessagePack-CSharp:develop Aug 13, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants