-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 8 Update(6): CollectionsMarshal for ListFormatter #1732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Did you happen to measure perf impact of this change?
The below benchmarks were done without Dynamic PGO. List<byte>
List<Matrix4x4>
|
For smaller value types,
Considering the above facts, let's revert the change for |
List<T>
for loop is slower thanSpan<T>
for loop.CollectionsMarshal.AsSpan
convertsList<T>
toSpan<T>
CollectionsMarshal.SetCount
can be used for deserialize.