New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mpc]: Ignore missing Include attribute in PackageReference tag #921

Merged

AArnott merged 1 commit into MessagePack-CSharp:master from waitxd:fix-mpc-packagereference

May 6, 2020

Contributor

waitxd commented May 6, 2020

mpc is trying to resolve nuget dependencies by itself.
If you reference e.g. MSBuild task, mpc fails on this code:

<PackageReference Update="@(PackageReference)" PrivateAssets="All" />

Probably, we can exclude PrivateAssets="all" from analysis as well.
But this is not covered by this PR.


          Allow mpc to ignore missing Include attribute in PackageReference tag…

22863ee

… while parsing .csproj

AArnott approved these changes

View reviewed changes

Collaborator

AArnott left a comment

Thanks

AArnott merged commit 802f472 into MessagePack-CSharp:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment