Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BSON implementation from Json.NET #976

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Add BSON implementation from Json.NET #976

merged 1 commit into from
Jul 10, 2020

Conversation

kzu
Copy link
Contributor

@kzu kzu commented Jul 10, 2020

I got an error when the value to serialize was a primitive,
since it seems BSON only supports objects and arrays as
top-level objects, to I just made it a one-element array
in that case.

I got an error when the value to serialize was a primitive,
since it seems BSON only supports objects and arrays as
top-level objects, to I just made it a one-element array
in that case.
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Any teaser as to the results you saw?

@kzu
Copy link
Contributor Author

kzu commented Jul 10, 2020

Yes: layering a GzipStream on top of plain Json.Net is vastly superior, in terms of size and also processing time.

So, not good for Bson.Net IMHO.

@AArnott AArnott merged commit 3124cb3 into MessagePack-CSharp:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants