Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit with proposed directory structure and regrouped funtions #14

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

balazagi
Copy link
Contributor

Some of the functions need external packages such as Improver and Ascend not sue what is the best way to include these! any ideas?

@nhsavage
Copy link
Collaborator

nhsavage commented Apr 1, 2020

I think that before we merge this the existing contents of the scripts folder (which are now in modules in lib/catnip) should be deleted

@nhsavage nhsavage self-requested a review April 1, 2020 12:30
@nhsavage nhsavage assigned balazagi and unassigned nhsavage Apr 1, 2020
@balazagi
Copy link
Contributor Author

balazagi commented Apr 2, 2020

removed the old scripts folder but keeping the branch alive for any further changes that need pull request

@nhsavage
Copy link
Collaborator

nhsavage commented Apr 2, 2020

can you please add some explaination of why the files under docs were removed on the changeset 2c88fa8 ?

@nhsavage nhsavage merged commit da08959 into master Apr 2, 2020
Copy link
Collaborator

@nhsavage nhsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved and comitted

This was referenced Apr 8, 2020
@balazagi balazagi deleted the 1-functions_regrouping branch April 8, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants