Add documentation on rational #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
commented
May 19, 2023
jfrost-mo
force-pushed
the
rational-documentation
branch
from
8f1092f
to
8fafa00
Compare
Sylviabohnenstengel
requested changes
May 22, 2023
|
Your changes look good to me, and definitely read better. I've just fixed a typo and reflowed the text, so it should be good to be approved now. |
Sylviabohnenstengel
approved these changes
May 22, 2023
jfrost-mo
force-pushed
the
rational-documentation
branch
from
fd0f4a8
to
82f8b3c
Compare
|
I just need to pin down why the tests are failing. Its a little odd since we didn't actually change any code, and its only failing under python 3.8. |
|
Ah, for some reason the python 3.8 tests are running with iris 3.1 (quite an old version). fortunately this is an easy fix. |
|
I've added some minimum versions to core dependencies to prevent conda deciding to use really old versions sometimes. I should probably have done this a while ago, but it hasn't been a problem until now. |
minor tweaks added
This stops conda resolving with a really old version that doesn't actually work for us.
jfrost-mo
force-pushed
the
rational-documentation
branch
from
93d98cd
to
5e77b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some reasons why one would use CSET. This is partly to help promote it, but also helps to clarify the aims of the project for the developers.