Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use recipes from environment variable #122

Merged
merged 11 commits into from
Jun 16, 2023
Merged

Use recipes from environment variable #122

merged 11 commits into from
Jun 16, 2023

Conversation

jfrost-mo
Copy link
Member

This change allows using a recipe from the CSET_RECIPE environment variable.

Depends on #119

@jfrost-mo jfrost-mo added the enhancement New feature or request label Jun 14, 2023
@jfrost-mo jfrost-mo self-assigned this Jun 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023 •
edited

Coverage

@jfrost-mo
Copy link
Member Author

jfrost-mo commented Jun 14, 2023 •
edited

TODO: Add test case for passing in recipe through environment variable. - Done

@jfrost-mo jfrost-mo marked this pull request as ready for review June 15, 2023 12:30
@jfrost-mo
Copy link
Member Author

Once this is merged we should also cut a release of CSET.

Sylviabohnenstengel
Sylviabohnenstengel requested changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@Sylviabohnenstengel Sylviabohnenstengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change: can we rename spacial to spatial for the test please?

@jfrost-mo
Copy link
Member Author

jfrost-mo commented Jun 16, 2023 •
edited

small change: can we rename spacial to spatial for the test please?

Fixed with 7df0da1

@jfrost-mo jfrost-mo removed the request for review from Sylviabohnenstengel June 16, 2023 08:07
@jfrost-mo
Copy link
Member Author

Bypassing review as it was a very small amendment.

@jfrost-mo jfrost-mo merged commit cd31a78 into main Jun 16, 2023
5 checks passed
@jfrost-mo jfrost-mo deleted the recipe-envvar branch June 16, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sylviabohnenstengel Sylviabohnenstengel Sylviabohnenstengel requested changes

Assignees

@jfrost-mo jfrost-mo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfrost-mo @Sylviabohnenstengel