Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graph command to visualise recipe files #136

Merged
merged 23 commits into from
Jul 5, 2023
Merged

Add graph command to visualise recipe files #136

merged 23 commits into from
Jul 5, 2023

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Jun 30, 2023 •
edited

Fixes #111
Fixes #139

@jfrost-mo jfrost-mo added the enhancement New feature or request label Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited

Coverage

@jfrost-mo
Add pygraphviz as dependency
56e799b 
[CI] Update conda lock files
@jfrost-mo jfrost-mo marked this pull request as ready for review July 3, 2023 16:27
@jfrost-mo jfrost-mo requested review from jwarner8 and removed request for jwarner8 July 3, 2023 16:27
@jfrost-mo
Add usage documentation for cset graph command
e230958
@jfrost-mo
Rename cset operators command to cset run
5bce7ea 
Also fixed some outdated references in the documentation.
@jfrost-mo
Fix tests to use cset run
6d77afe
@jfrost-mo
Break up tests into smaller units
dc31d2c 
This should both allow us to parallise it better, as well as narrow
down issues more when something fails.
@jfrost-mo
Copy link
Member Author

@jwarner8 I've added documentation for the cylc graph command, and done some refactoring on the tests since your last review. Once those are approved we can merge this PR.

A rendered version of the changed documentation is here: https://tmpweb.net/2QRA0_x1SjQc/usage/

The cylc graph command can produce a normal view, and a detailed view. You can see both at #111 (comment)
If you can think of any other information that would be useful to have there, or any other improvements to the graph view, please do say.

@jfrost-mo jfrost-mo requested a review from jwarner8 July 4, 2023 10:09
@jfrost-mo
Copy link
Member Author

I appologies for this being such a big PR. I should really try to break it up better in future.

jwarner8
jwarner8 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, I find the documentation easy to follow. The test will be doing it myself!!

@jfrost-mo
Copy link
Member Author

I'll merge this in tomorrow morning.

@jfrost-mo jfrost-mo merged commit 4913e5b into main Jul 5, 2023
5 checks passed
@jfrost-mo jfrost-mo deleted the cset-graph branch July 5, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwarner8 jwarner8 jwarner8 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename operators command to bake Graphically visualise recipe files
2 participants
@jfrost-mo @jwarner8