Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to create recipes on disk #140

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Add command to create recipes on disk #140

merged 8 commits into from
Jul 6, 2023

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Jul 4, 2023

This PR moves the recipes out of the internals of the operators module, and removes any direct internal reference to them in favour of always using files, as discussed in #103.

As part of this a new command has been implemented to create the default recipe files on disk, though I haven't yet though up a name.

Still to do

  • Tests
  • Documentation
  • Name command

Fixes #103

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Coverage

@jfrost-mo
Copy link
Member Author

I'm liking cset cookbook, or maybe cset unpack for the command name.

@jfrost-mo jfrost-mo added the enhancement New feature or request label Jul 5, 2023
@jfrost-mo jfrost-mo force-pushed the recipe_seperation branch 2 times, most recently from 850e516 to aa27e08 Compare July 5, 2023 14:02
@jfrost-mo jfrost-mo mentioned this pull request Jul 5, 2023
@jfrost-mo jfrost-mo force-pushed the recipe_seperation branch 6 times, most recently from ebfdd2e to 792bc4d Compare July 6, 2023 07:08
Allow unpack-recipe command handle subdirectories of recipes

This will allow us to categorise recipes in future.

Move inner unpack function to top level to aid testing
Also clarify variable names in CLI interface module.
@jfrost-mo jfrost-mo marked this pull request as ready for review July 6, 2023 10:57
@jfrost-mo jfrost-mo requested a review from jwarner8 July 6, 2023 10:57
@jfrost-mo jfrost-mo merged commit a667489 into main Jul 6, 2023
5 checks passed
@jfrost-mo jfrost-mo deleted the recipe_seperation branch July 6, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move recipes into this repository and provide convenient download of them
2 participants