-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to create recipes on disk #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrost-mo
force-pushed
the
recipe_seperation
branch
from
July 5, 2023 07:44
cda6506
to
7942ad6
Compare
I'm liking |
jfrost-mo
force-pushed
the
recipe_seperation
branch
from
July 5, 2023 07:53
b66c6dc
to
9b7299c
Compare
jfrost-mo
force-pushed
the
recipe_seperation
branch
2 times, most recently
from
July 5, 2023 14:02
850e516
to
aa27e08
Compare
Merged
jfrost-mo
force-pushed
the
recipe_seperation
branch
6 times, most recently
from
July 6, 2023 07:08
ebfdd2e
to
792bc4d
Compare
Allow unpack-recipe command handle subdirectories of recipes This will allow us to categorise recipes in future. Move inner unpack function to top level to aid testing
Also clarify variable names in CLI interface module.
jfrost-mo
force-pushed
the
recipe_seperation
branch
from
July 6, 2023 08:35
792bc4d
to
17eb386
Compare
jfrost-mo
force-pushed
the
recipe_seperation
branch
from
July 6, 2023 10:17
f651f5e
to
bfdfd5f
Compare
jwarner8
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the recipes out of the internals of the operators module, and removes any direct internal reference to them in favour of always using files, as discussed in #103.
As part of this a new command has been implemented to create the default recipe files on disk, though I haven't yet though up a name.
Still to do
Fixes #103