General cleanup #158
Merged
General cleanup #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't possible to run CSET in it, so it is better off to use the main environment.
Currently the cube metadata that is written and the cube metadata that is read back are slightly different (realization AuxCoord becomes a DimCoord), which causes the comparison to fail. We should be covering this code with other tests anyway, and I don't expect much change here so it should be fine.
|
|
4 tasks
jfrost-mo
commented
Jul 14, 2023
Suggestions from code review
jfrost-mo
force-pushed
the
general-cleanup
branch
from
8721a29
to
a237257
Compare
jwarner8
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small miscellaneous improvements that should be merged before #157