Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to use PyTest helpers #177

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Aug 1, 2023

Uses the exception testing and tmp_path helpers to significantly clean up tests.

Fixes #165.

@jfrost-mo jfrost-mo added the cleanup Non-functional improvement label Aug 1, 2023
@jfrost-mo jfrost-mo self-assigned this Aug 1, 2023
@jfrost-mo jfrost-mo marked this pull request as ready for review August 1, 2023 09:37
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Coverage

@jfrost-mo jfrost-mo mentioned this pull request Aug 1, 2023
5 tasks
@jfrost-mo jfrost-mo force-pushed the 165_pytest_exception_refactor branch 2 times, most recently from de0fcdc to 193525c Compare August 1, 2023 12:32
@jfrost-mo jfrost-mo force-pushed the 165_pytest_exception_refactor branch from 193525c to 24e107e Compare August 3, 2023 15:46
@jfrost-mo jfrost-mo requested a review from jwarner8 August 4, 2023 08:06
@jfrost-mo
Copy link
Member Author

I'm on leave for the next week, so go ahead and merge this if you are happy with it. Otherwise I'll get to any comments when I'm back.

@jfrost-mo jfrost-mo merged commit 327d761 into main Aug 14, 2023
5 checks passed
@jfrost-mo jfrost-mo deleted the 165_pytest_exception_refactor branch August 14, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor exception testing to use pytest builtin
2 participants