Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postage stamp plot fix #181

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Postage stamp plot fix #181

merged 2 commits into from
Aug 3, 2023

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Aug 3, 2023

This fix allows postage stamp plots to be created from MOGREPS-UK data.

It also generalises it so it can do postage stamp plots of other fields than realization, tough I don't know if there will be too much interest in that.

@jfrost-mo jfrost-mo added the bug Something isn't working label Aug 3, 2023
@jfrost-mo jfrost-mo self-assigned this Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review August 3, 2023 14:10
@jfrost-mo jfrost-mo requested a review from jwarner8 August 3, 2023 14:10
@Sylviabohnenstengel Sylviabohnenstengel requested review from Sylviabohnenstengel and removed request for jwarner8 August 3, 2023 15:29
@Sylviabohnenstengel
Copy link
Contributor

This fix allows postage stamp plots to be created from MOGREPS-UK data.

It also generalises it so it can do postage stamp plots of other fields than realization, tough I don't know if there will be too much interest in that.

One further application for postage stamps would be to plot them not by realisation but by a stratified criteria

Copy link
Contributor

@Sylviabohnenstengel Sylviabohnenstengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with the suggestion. Please not my comment regarding realisation time.

@Sylviabohnenstengel Sylviabohnenstengel merged commit 3c28481 into main Aug 3, 2023
5 checks passed
@Sylviabohnenstengel Sylviabohnenstengel deleted the postage_stamp_plot_fix branch August 3, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants