Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update why-cset.rst #227

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Update why-cset.rst #227

merged 5 commits into from
Nov 9, 2023

Conversation

Sylviabohnenstengel
Copy link
Contributor

substantial re-write

substantial re-write
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Coverage

@Sylviabohnenstengel
Copy link
Contributor Author

HOw do I get rid of the trailing white space if editing through the github browser please?

@jfrost-mo
Copy link
Member

The trailing whitespace is where you have multiple (or none) newlines at the end of the file.

TBH the GitHub browser editor isn't great for that kind of thing. I'll check it out locally and reflow the text.

Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small edits.

docs/source/background/why-cset.rst Outdated Show resolved Hide resolved
docs/source/background/why-cset.rst Outdated Show resolved Hide resolved
docs/source/background/why-cset.rst Outdated Show resolved Hide resolved
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
@Sylviabohnenstengel
Copy link
Contributor Author

changes addressed. thanks you :-)

@jfrost-mo jfrost-mo self-requested a review November 9, 2023 10:24
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jfrost-mo jfrost-mo merged commit 68b4ad7 into main Nov 9, 2023
5 checks passed
@jfrost-mo jfrost-mo deleted the Sylviabohnenstengel-patch-4 branch November 9, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants