Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source workflow #247

Merged
merged 18 commits into from
Dec 7, 2023
Merged

Open source workflow #247

merged 18 commits into from
Dec 7, 2023

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Nov 13, 2023

Fixes https://github.com/MetOffice/CSET-workflow/issues/146. That issue has quite a lot of design discussion around this change, so is worth a read before reviewing.

Most additions are just what was in the workflow, so doesn't need to much attention. The only change I've made to the code is adding a few more docstrings and fixing a couple minor lints.

The bits that require scrutiny are the restricted files install script, and making sure I've drawn the repository boundaries correctly.

Also note that the install script clones the main branch by default, so you will want to set it to 146_remove_open_sourced_code instead while the excess hasn't been removed.

@jfrost-mo jfrost-mo added enhancement New feature or request cleanup Non-functional improvement labels Nov 13, 2023
@jfrost-mo jfrost-mo self-assigned this Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review December 1, 2023 16:15
Copy link
Collaborator

@JorgeBornemann JorgeBornemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. The changes to the open vs restricted repositories are as discussed, and to me are very reasonable, but once the other partners start testing and implementing their site-specific information we may have to do some fine adjustment.
One possible future improvement could be to code a wrapper (i.e. cset_run_workflow) for the cylc vip command so the workflow can be constructed and run in one go, but it needs a lot more thinking.
Note that I didn't have time to test the branch in our installation. If something goes wrong we can deal with it in another issue.
I leave to you committing the branches, as you have a good plan already on the order they have to be committed.

@jfrost-mo
Copy link
Member Author

I though about having a wrapper script, but didn't want to hide the cylc 8 commands, as that would make CSET different to most other workflows. I'm open for more discussion and ideas in future though. I'll go ahead and merge this now and we can improve it in follow up issues.

@jfrost-mo jfrost-mo merged commit 4f8ac5f into main Dec 7, 2023
5 checks passed
@jfrost-mo jfrost-mo deleted the w146_open_source_workflow branch December 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants