Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot generation improvements #274

Merged
merged 15 commits into from
Nov 23, 2023
Merged

Plot generation improvements #274

merged 15 commits into from
Nov 23, 2023

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Nov 21, 2023 •
edited

Fixes #248 and paves the way to future plot improvements.

This makes future plot improvements much easier. I'll have another PR soon to improve the contour plot.

@jfrost-mo jfrost-mo added the enhancement New feature or request label Nov 21, 2023
@jfrost-mo jfrost-mo self-assigned this Nov 21, 2023
@jfrost-mo
Copy link
Member Author

jfrost-mo commented Nov 21, 2023 •
edited

#240 should also be included in this PR. Because its gotten fairly large I'll actually do a second PR.

@jfrost-mo
Copy link
Member Author

The conda lockfiles will need regenerating as part of this PR.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023 •
edited

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review November 23, 2023 14:34
@jfrost-mo jfrost-mo changed the title Plot improvements Plot generation improvements Nov 23, 2023
@Sylviabohnenstengel
Update plot.py
ee69331 
subtle change
Sylviabohnenstengel
Sylviabohnenstengel approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Sylviabohnenstengel Sylviabohnenstengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to tiny change :-)

@jfrost-mo
Copy link
Member Author

I'll make a release for CSET after merging this.

@Sylviabohnenstengel Sylviabohnenstengel merged commit c75c458 into main Nov 23, 2023
5 checks passed
@Sylviabohnenstengel Sylviabohnenstengel deleted the 240_plot_improvements branch November 23, 2023 15:16
@jfrost-mo jfrost-mo mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sylviabohnenstengel Sylviabohnenstengel Sylviabohnenstengel approved these changes

Assignees

@jfrost-mo jfrost-mo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate HTML in plotting operator rather than workflow task
2 participants
@jfrost-mo @Sylviabohnenstengel