CAPE ratio diagnostic #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daflack
added
enhancement
|
|
jfrost-mo
requested changes
Dec 12, 2023
fixes review suggestions Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
jfrost-mo
reviewed
Dec 12, 2023
jfrost-mo
approved these changes
Dec 12, 2023
JorgeBornemann
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
It looks good, and I can't see this change causing any problem with portability; however, I can't test in our installation at the moment as I don't have any model output with the three diagnostics required (I am working on it).
Two very minor comments:
- The help in the metadata for the GUI could specify explicitly the stash codes for the three required model diagnostics, or at least warn the user that model diagnostics other than the 'standard' ones are required.
- There is an inconsistency between the default value for
MUCIN_threshbetween the recipe (-30 J/Kg) and the code (-75 J/Kg), is that intentional?, one would expect that both the recipe and the default will have the most common value.
Approved for portability.
jwarner8
approved these changes
Dec 14, 2023
jfrost-mo
reviewed
Dec 14, 2023
daflack
commented
Dec 15, 2023
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #324