Graceful error when graphing without xdg-open #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non-desktop systems, such as HPCs, xdg-open doesn't exist. The created file can still be viewed manually, and the new error helps users discover the -o option to set the output. Fixes #393
jfrost-mo
added
bug
|
|
This makes use of mocked versions of xdg-open, but is the best we can do without having graphical test runners.
jfrost-mo
force-pushed
the
393_graph_auto-open_fallback
branch
from
58d1c6c
to
178b0b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-desktop systems, such as HPCs, xdg-open doesn't exist. The created file can still be viewed manually, and the new error helps users discover the -o option to set the output.
Fixes #393
The new output if xdg-open fails is thus:
To do: