Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LD_LIBRARY_PATH being unset #404

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Feb 29, 2024

This improves portability at sites that don't set this path by default. (Such as NCI in Australia.)

Also prepend to the path so that the CSET libraries are used preferentially.

Fixes #402

This improves portability at sites that don't set this path by default.

Also prepend to the path so that the CSET libraries are used preferentially.

Fixes #402
@jfrost-mo jfrost-mo added bug Something isn't working portability Ensuring functionality at other sites labels Feb 29, 2024
@jfrost-mo jfrost-mo marked this pull request as ready for review February 29, 2024 11:57
Copy link
Contributor

Coverage

@jfrost-mo
Copy link
Member Author

jfrost-mo commented Feb 29, 2024

NOTE: if merged soon release a 24.2.1 patch release with the other fixes on main.

@jfrost-mo jfrost-mo requested a review from jwarner8 March 1, 2024 09:19
@jfrost-mo
Copy link
Member Author

This change has been successfully tested by me at the Met Office and on NCI.

Copy link
Member Author

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been tested on NCI & Met Office, and change is very targeted. Merging without review so I can make a bugfix release today.

@jfrost-mo jfrost-mo merged commit 683fb3c into main Mar 4, 2024
8 checks passed
@jfrost-mo jfrost-mo deleted the 402_LD_LIBRARY_PATH_portability_fix branch March 4, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working portability Ensuring functionality at other sites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cylc-workflow: install_local_cset task failing on NCI, Australia
1 participant