Basic regrid operator #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
There is some repetition within both operators in determining the x,y coordinate names. We might want to have this as a separate operator/utility? |
jfrost-mo
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Overall looking like a solid addition to CSET capability, and one that will be very useful going forwards.
I've noted some things that need tweaking, along with some things I would like additional documentation for, and wanting some additional tests. I'm happy to discuss how to go about these various things.
tidy docstring Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
update copyright Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
update docstring Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
jfrost-mo
reviewed
Mar 25, 2024
jfrost-mo
requested changes
Mar 25, 2024
jfrost-mo
reviewed
Mar 26, 2024
Fixes a pre-commit issue apparently only in CI?
|
I'm not sure why the pre-commit check was not failing locally, but I've fixed it manually. |
* Missing coordinates, * Invalid and nonexistent regridding method, * Invalid coordinate systems.
jfrost-mo
reviewed
Apr 5, 2024
Additional regridding tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New operators and test to regrid basic rectilinear Geos data using a Linear regridder, with capacity to be expanded to handle other grids/new regrid methods.
Fixes #154