Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

446 ifs in build conda #447

Merged
merged 4 commits into from
Mar 26, 2024
Merged

446 ifs in build conda #447

merged 4 commits into from
Mar 26, 2024

Conversation

JorgeBornemann
Copy link
Collaborator

All shell scripts that use module load modified to set IFS to a single space for the loop that loads the module, returning it after to its original value.

Set IFS to spaces for module load loop only
set IFS to space for loading modules only
Copy link
Contributor

github-actions bot commented Mar 26, 2024

Coverage

Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs some quoting, then go ahead and merge.

cset-workflow/bin/app_env_wrapper Outdated Show resolved Hide resolved
cset-workflow/app/build_conda/bin/build_conda_env.sh Outdated Show resolved Hide resolved
JorgeBornemann and others added 2 commits March 26, 2024 23:24
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
@JorgeBornemann JorgeBornemann merged commit 0bb1a60 into main Mar 26, 2024
8 checks passed
@JorgeBornemann JorgeBornemann deleted the 446-ifs-in-build_conda branch March 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting IFS in build_conda_env.sh script disrupts sourcing conda via module load
2 participants