Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generic arithmetic operators #452

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Added generic arithmetic operators #452

merged 2 commits into from
Apr 18, 2024

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Mar 26, 2024

fixes #451

@daflack
Copy link
Contributor Author

daflack commented Mar 26, 2024 •
edited

Recipes not added as these operators are needed for April RMED Quest. A filtered CAPE ratio recipe will be coming in the future see #429.

@daflack daflack requested a review from jfrost-mo March 26, 2024 12:25
@jfrost-mo jfrost-mo added the full_review Requires a technical, scientific, and portability review label Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited

Coverage

jfrost-mo
jfrost-mo reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good from a technical standpoint. The main thing that needs working out is what to call the argument names for the operators, as the argument names are used in the recipe.

- operator: misc.division
  a: <first cube>
  b: <second cube>

src/CSET/operators/misc.py Outdated Show resolved Hide resolved
src/CSET/operators/misc.py Outdated Show resolved Hide resolved
tests/operators/test_misc.py Outdated Show resolved Hide resolved
tests/operators/test_misc.py Outdated Show resolved Hide resolved
@daflack daflack requested a review from jfrost-mo March 26, 2024 16:28
jfrost-mo
jfrost-mo requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code simplifications, happy to approve afterwards.

src/CSET/operators/misc.py Outdated Show resolved Hide resolved
src/CSET/operators/misc.py Outdated Show resolved Hide resolved
src/CSET/operators/misc.py Outdated Show resolved Hide resolved
src/CSET/operators/misc.py Outdated Show resolved Hide resolved
@jfrost-mo jfrost-mo self-requested a review March 26, 2024 16:40
jfrost-mo
jfrost-mo approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though let's let this go through the full review process, as a matter of principle.

@jfrost-mo jfrost-mo added the enhancement New feature or request label Mar 28, 2024
@jfrost-mo jfrost-mo force-pushed the 451_generic_arithmetic_operators branch from e2abf68 to 58893e5 Compare April 18, 2024 09:37
@jfrost-mo
Copy link
Member

Fixed merge conflicts.

@jfrost-mo jfrost-mo merged commit 192bff9 into main Apr 18, 2024
8 checks passed
@jfrost-mo jfrost-mo deleted the 451_generic_arithmetic_operators branch April 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sylviabohnenstengel Sylviabohnenstengel Sylviabohnenstengel approved these changes

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees

@daflack daflack

Labels
enhancement New feature or request full_review Requires a technical, scientific, and portability review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic arithmetic operators
3 participants
@daflack @jfrost-mo @Sylviabohnenstengel