Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable iris save_split_attrs behavour #459

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Enable iris save_split_attrs behavour #459

merged 1 commit into from
Apr 17, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Mar 26, 2024 •
edited

Fixes new iris warning:

IrisDeprecation: Saving to netcdf with legacy-style attribute handling for backwards compatibility.
  This mode is deprecated since Iris 3.8, and will eventually be removed.
  Please consider enabling the new split-attributes handling mode, by setting 'iris.FUTURE.save_split_attrs = True'.

Per discussion with iris team this is fixing inconsistent behavour and making data easier to round trip. It shouldn't specifically affect us so we can go ahead and fix it.

Fixes #458

@jfrost-mo jfrost-mo self-assigned this Mar 26, 2024
@jfrost-mo jfrost-mo added small Small issue that should be quick to resolve cleanup Non-functional improvement labels Mar 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review March 26, 2024 15:15
@Sylviabohnenstengel Sylviabohnenstengel merged commit ce12bb9 into main Apr 17, 2024
8 checks passed
@Sylviabohnenstengel Sylviabohnenstengel deleted the 458_iris_depracation_fix branch April 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sylviabohnenstengel Sylviabohnenstengel Sylviabohnenstengel approved these changes

Assignees

@jfrost-mo jfrost-mo

Labels
cleanup Non-functional improvement small Small issue that should be quick to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iris deprecation warning about legacy-style attribute handling
2 participants
@jfrost-mo @Sylviabohnenstengel