Add LFRic specific recipes #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The UMified LFRic data contains cell methods about being a time point, where the UM has no methods in that case.
jfrost-mo
force-pushed
the
309_lfric_test
branch
from
a8403e7
to
f872a51
Compare
|
The time coordinate merge issue comes from a um_stash_souce attribute having multiple values sorted in different orders. Either sorting or dropping that attribute should fix it. |
|
TODO: Tomorrow test with the non-UMified SLAMed data, in |
This attribute lists multiple STASH codes for that LFRic field, however the order these codes are listed can vary, causing the cubes to not merge.
Treat strings as atoms, rather than iterating over characters.
They are per file attributes, that have no bearing on the actual data within, but prevent the cubes merging.
Pytest doesn't pick up the warning for some reason though. This might be related to logging.captureWarnings, but removing that doesn't seem to help.
Non-UMified LFRic handling
Sylviabohnenstengel
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UMified LFRic data contains cell methods about being a time point, where the UM has no methods in that case.
Fixes #309
Fixes #487