Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename steps and post steps to parallel and collate #484

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Apr 12, 2024

Fixes #479

Athough it looks like a lot of changes, most of it is just renaming. The substantive changes are contained within src/CSET/_common.py and src/CSET/operators/__init__.py, which involved cleaning up the recipe validator, and supporting a fall back to the old names, with a DeprecationWarning.

@jfrost-mo jfrost-mo added documentation Improvements or additions to documentation cleanup Non-functional improvement labels Apr 12, 2024
@jfrost-mo jfrost-mo self-assigned this Apr 12, 2024
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review April 12, 2024 14:38
Copy link
Contributor

@astroDimitrios astroDimitrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to a CSET novice. I made a couple of comments about wording you might want to look at.

@jfrost-mo jfrost-mo force-pushed the 479_rename_steps_and_post-steps branch from eb2bd63 to ec6d757 Compare April 18, 2024 08:08
@jfrost-mo
Copy link
Member Author

Fixed merge conflicts.

They were added after the inital conversion.
@jfrost-mo jfrost-mo merged commit bfb221e into main Apr 18, 2024
8 checks passed
@jfrost-mo jfrost-mo deleted the 479_rename_steps_and_post-steps branch April 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

steps and post-steps are rubbish names
2 participants