-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename steps and post steps to parallel and collate #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrost-mo
added
documentation
Improvements or additions to documentation
cleanup
Non-functional improvement
labels
Apr 12, 2024
jfrost-mo
requested review from
JorgeBornemann,
Sylviabohnenstengel and
astroDimitrios
and removed request for
Sylviabohnenstengel
April 12, 2024 14:44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to a CSET novice. I made a couple of comments about wording you might want to look at.
astroDimitrios
approved these changes
Apr 17, 2024
Co-authored-by: Dimitrios Theodorakis <astrodimitrios@gmail.com>
jfrost-mo
force-pushed
the
479_rename_steps_and_post-steps
branch
from
April 18, 2024 08:08
eb2bd63
to
ec6d757
Compare
Fixed merge conflicts. |
They were added after the inital conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479
Athough it looks like a lot of changes, most of it is just renaming. The substantive changes are contained within
src/CSET/_common.py
andsrc/CSET/operators/__init__.py
, which involved cleaning up the recipe validator, and supporting a fall back to the old names, with a DeprecationWarning.