Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken and redundent recipes #512

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Apr 19, 2024

Description

Removes redundant recipes identified in #498. Also includes a clean up on a couple recipes we are keeping.

Fixes #498

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Added an entry to the top of docs/source/changelog.rst
  • Conda lock files have been updated if dependencies changed.
  • Marked the PR as ready to review.

Also includes a fixup on a couple recipes we are keeping.

Fixes #498
@jfrost-mo jfrost-mo added the cleanup Non-functional improvement label Apr 19, 2024
@jfrost-mo
Copy link
Member Author

One of the removed recipes was used for testing the cookbook command. Fixing...

The previous one was removed.
Copy link
Contributor

github-actions bot commented Apr 19, 2024

Coverage

@jfrost-mo jfrost-mo marked this pull request as ready for review April 19, 2024 12:45
@jfrost-mo jfrost-mo self-assigned this Apr 19, 2024
@jfrost-mo
Copy link
Member Author

The mean_surface_air_temperature_spatial_plot.yaml recipe is used in the documentation, so probably should be kept.

@Sylviabohnenstengel Sylviabohnenstengel merged commit 4af60b4 into main May 13, 2024
7 checks passed
@Sylviabohnenstengel Sylviabohnenstengel deleted the 498_remove_old_recipes branch May 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old and redundent recipes
2 participants