Add functionality to filter by region #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
changed the title
jfrost-mo
reviewed
May 10, 2024
cset-workflow/includes/lfric_deterministic_domain_mean_surface_time_series.cylc
Outdated
Show resolved
Hide resolved
cset-workflow/includes/lfric_deterministic_domain_mean_surface_time_series.cylc
Outdated
Show resolved
Hide resolved
cset-workflow/includes/lfric_plot_spatial_surface_model_field.cylc
Outdated
Show resolved
Hide resolved
cset-workflow/includes/lfric_plot_spatial_surface_model_field.cylc
Outdated
Show resolved
Hide resolved
|
@jfrost-mo think I'm done, let me know if you've got any other comments |
jfrost-mo
approved these changes
May 10, 2024
There was a problem hiding this comment.
Thanks for addressing the feedback. The only question I've got left is what is tests/test_data/air_temp.nc.aux.xml used for? I can't find any other references to it in the code.
|
I'll go ahead and merge then. |
jfrost-mo
force-pushed
the
400_support_filtering_to_region
branch
from
fba2732
to
a9d541a
Compare
…_time_series.cylc Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
…_time_series.cylc Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
…cylc Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
…cylc Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
Co-authored-by: James Frost <james.frost@metoffice.gov.uk>
jfrost-mo
force-pushed
the
400_support_filtering_to_region
branch
from
a9d541a
to
54a1b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch enables the user to filter the data by geographic region defined in a shapefile (geospatial vector data) format.
Fixes #400
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
docs/source/changelog.rst