Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbar #570

Merged
merged 20 commits into from
May 10, 2024
Merged

Colorbar #570

merged 20 commits into from
May 10, 2024

Conversation

cjohnson-pi
Copy link
Contributor

Description

Fixes #456

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Added an entry to the top of docs/source/changelog.rst
  • Conda lock files have been updated if dependencies changed.
  • Marked the PR as ready to review.

@cjohnson-pi cjohnson-pi reopened this Apr 30, 2024
Copy link
Contributor

github-actions bot commented Apr 30, 2024

Coverage

cset-workflow/extra-meta/colorbar_dict.json Outdated Show resolved Hide resolved
cset-workflow/meta/rose-meta.conf Outdated Show resolved Hide resolved
cset-workflow/meta/rose-meta.conf Outdated Show resolved Hide resolved
src/CSET/operators/plot.py Outdated Show resolved Hide resolved
src/CSET/operators/plot.py Outdated Show resolved Hide resolved
@jfrost-mo jfrost-mo marked this pull request as ready for review May 9, 2024 07:49
@jfrost-mo jfrost-mo self-requested a review May 9, 2024 07:49
cset-workflow/extra-meta/colorbar_dict_alphabetical.json Outdated Show resolved Hide resolved
src/CSET/operators/__init__.py Outdated Show resolved Hide resolved
src/CSET/operators/plot.py Show resolved Hide resolved
Previously the None would serialise to the string "None", which could
have matched a file with that name.
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy for this to be merged now. We still need to document and test a bit better, but I've opened separate issues to continue after this PR has been merged.

@jfrost-mo jfrost-mo merged commit d8c6067 into main May 10, 2024
8 checks passed
@jfrost-mo jfrost-mo deleted the colorbar branch May 10, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appropriate colour bars for different field types
2 participants