-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create common operators script #620
Conversation
Linked #619 |
If you edit the initial comment, and put the issue number after the "Fixes #" bit, it will properly link, and close the issue when this PR is merged. |
I put in the identification of horizontal coordinate names as a generic function useful for many operators as a start. Not convinced if |
Not very creative, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. The only thing left is whether this code should be used from somewhere before it is merged. I know it will be used in your Age of Air diagnostic, but is it used anywhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its not used anywhere in the current code, we can still go ahead and merge it, and you'll want to update your Age of Air branch to take advantage of it.
After this gets merged, it will immediately be used within the regrid operator, and I will create a new PR/issue for updating this operator to use the common function. Then, I will work on the age of air review, which uses the regrid operator as part of the recipe. The cross section work will directly make use of the common function too |
I figured probably easier to merge this first and then update regrid, rather than update regrid operator in this PR too (so the PR's have a clear separate purpose)? |
That works. Only other thing is to add an entry to the top of the changelog ( |
Create common operator script to hold regularly used iris/processing functionality that isn't an operator independently
Fixes #619
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
docs/source/changelog.rst