Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update regrid to use utils #626

Merged
merged 3 commits into from
May 17, 2024
Merged

update regrid to use utils #626

merged 3 commits into from
May 17, 2024

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented May 17, 2024 •
edited

Update regrid operator to use the generic utils function to identify x and y coordinates.

Fixes #

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Added an entry to the top of docs/source/changelog.rst
  • Conda lock files have been updated if dependencies changed.
  • Marked the PR as ready to review.

@github-actions GitHub Actions
Copy link
Contributor

Coverage

@jwarner8 jwarner8 marked this pull request as ready for review May 17, 2024 09:54
@jwarner8 jwarner8 requested a review from jfrost-mo May 17, 2024 09:54
jfrost-mo
jfrost-mo approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Its always nice to see a change that removes code. Go ahead and merge.

@jwarner8 jwarner8 merged commit 95d229e into main May 17, 2024
7 checks passed
@jwarner8 jwarner8 deleted the update_regrid_operator branch May 17, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwarner8 @jfrost-mo