LFRic extension to vertical profile #638

Sylviabohnenstengel · 2024-05-23T11:09:12Z

Fixes #637

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

Documentation has been updated to reflect change.
New code has tests, and affected old tests have been updated.
All tests and CI checks pass.
Added an entry to the top of docs/source/changelog.rst
Conda lock files have been updated if dependencies have changed.
Said whether Generative AI, such as GitHub Copilot, has been used in this PR.
Marked the PR as ready to review.

github-actions · 2024-05-23T11:10:25Z

Sylviabohnenstengel · 2024-05-23T12:07:23Z

first requires review of Um version for vertical profile #494

jfrost-mo · 2024-06-24T13:12:22Z

The multilevel data we currently have is UMified, so we should first check with Dasha about getting some SLAM only data.

Sylviabohnenstengel · 2024-06-25T10:45:21Z

Dasha has provided slam only data. The lfric data vertical coordinate is full_levels and not model_level_number like in the um data. recipe, constraint and plot code have been adjusted for that.

Sylviabohnenstengel · 2024-06-25T10:45:49Z

need to keep in mind that some lfric data migth operate on half_levels and others on full_levels.

Sylviabohnenstengel · 2024-06-25T10:46:39Z

recipe is working, but units are unknown for lfric data

Sylviabohnenstengel · 2024-06-25T16:09:50Z

GitHub Copilot was used to inform a few lines of code.

Sylviabohnenstengel · 2024-06-25T16:10:26Z

@jfrost-mo Do I need to add use of github copilot in the changelog?

jfrost-mo · 2024-06-25T16:15:15Z

You've added a comment to the PR, so that covers that. As this is the first PR that will be merged using GitHub Copilot, I'll also add a note to the README in the PR.

cset-workflow/includes/lfric_deterministic_domain_mean_vertical_profile_series.cylc

jfrost-mo

I've suggested a bunch of things. I'm happy to hop on a call and go through them if that would be helpful.

cset-workflow/includes/lfric_plot_spatial_mlevel_model_field.cylc

cset-workflow/includes/lfric_plot_spatial_plevel_model_field.cylc

cset-workflow/meta/rose-meta.conf

src/CSET/operators/plot.py

Sylviabohnenstengel

all approved bar the two changes that suggest to use "pressure" as default vertical coordinate as I think we will switch to model levels as lfric doe snot yet provide pressure levels. As we tend to explicitly pass this into the function via recipe it should not be an issue.

…se meta.

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

This does what we have been trying to do, in having a single operator that can handle all levels.

I added pressure to make it absolutely clear t=it generates constraints for all types of vertical levels

jfrost-mo

Happy to approve now.

Sylviabohnenstengel requested review from daflack and jfrost-mo May 23, 2024 11:09

Sylviabohnenstengel self-assigned this May 23, 2024

Sylviabohnenstengel added enhancement New feature or request science Scientific capabilities labels May 23, 2024

jfrost-mo changed the base branch from main to vertical_profiles_of_area_averaged_fields_494 May 23, 2024 13:13

jfrost-mo changed the title ~~637 lfric extension to vertical profile~~ LFRic extension to vertical profile May 23, 2024

jfrost-mo force-pushed the vertical_profiles_of_area_averaged_fields_494 branch from 7ae4310 to c53e945 Compare May 24, 2024 07:50

Base automatically changed from vertical_profiles_of_area_averaged_fields_494 to main May 29, 2024 09:07

jfrost-mo force-pushed the 637_lfric_extension_to_vertical_profile branch from 08884b0 to 2e93eb1 Compare June 24, 2024 11:15

Sylviabohnenstengel marked this pull request as ready for review June 25, 2024 16:04

Sylviabohnenstengel mentioned this pull request Jun 26, 2024

Extend UM vertical plotting to model level #697

Open

7 tasks

Sylviabohnenstengel requested review from dasha-shchep and removed request for daflack June 26, 2024 13:27

This was referenced Jun 26, 2024

Enable lfric spatial plotting on full level and half levels #694

Open

add lfric capability to vertical profile branch and for spatial plotting on plevels #637

Closed

dasha-shchep reviewed Jun 26, 2024

View reviewed changes

cset-workflow/includes/lfric_deterministic_domain_mean_vertical_profile_series.cylc Outdated Show resolved Hide resolved

jfrost-mo force-pushed the 637_lfric_extension_to_vertical_profile branch from ebc8c55 to 33cc79e Compare June 27, 2024 09:26

jfrost-mo requested changes Jun 27, 2024

View reviewed changes

jfrost-mo reviewed Jun 27, 2024

View reviewed changes

src/CSET/operators/plot.py Outdated Show resolved Hide resolved

Sylviabohnenstengel commented Jun 27, 2024

View reviewed changes

Sylviabohnenstengel and others added 25 commits July 1, 2024 11:32

removing triggers for lfric model levels and lfric model fields in ro…

83cc1db

…se meta.

ensure test functions deals with model levels

34bc2d3

Add GitHub Copilot attribution notice to README

0c7f2a5

Update cset-workflow/includes/lfric_plot_spatial_mlevel_model_field.cylc

fc8dcb8

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/includes/lfric_plot_spatial_mlevel_model_field.cylc

0f6baa7

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/includes/lfric_plot_spatial_plevel_model_field.cylc

bb16e6c

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/meta/rose-meta.conf

8b435d0

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/plot.py

551c244

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/plot.py

e8c7fe8

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/plot.py

b2693e7

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/includes/lfric_plot_spatial_plevel_model_field.cylc

332b11c

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/plot.py

3ba91df

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/constraints.py

e1b1aba

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Apply suggestions from code review

a5a5fdf

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Apply suggestions from code review

3b45f5b

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Apply suggestions from code review

02025ba

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update cset-workflow/meta/rose-meta.conf

548e484

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/constraints.py

8174036

Co-authored-by: James Frost <james.frost@metoffice.gov.uk>

Update src/CSET/operators/plot.py

4fb79cb

Add generic level constraint operator

cc811af

This does what we have been trying to do, in having a single operator that can handle all levels.

Update recipes to use generic level constraint operator

5cd1fc6

Convert tests to use generic level constraint

98729dc

Remove obsolete specific level constraint operators

d67a13c

Update constraints.py

7c22590

I added pressure to make it absolutely clear t=it generates constraints for all types of vertical levels

Reflow docstring

10f69ee

jfrost-mo force-pushed the 637_lfric_extension_to_vertical_profile branch from 477c4ca to 10f69ee Compare July 1, 2024 10:32

jfrost-mo approved these changes Jul 1, 2024

View reviewed changes

dasha-shchep approved these changes Jul 1, 2024

View reviewed changes

jfrost-mo merged commit 1091d80 into main Jul 1, 2024
7 checks passed

jfrost-mo deleted the 637_lfric_extension_to_vertical_profile branch July 1, 2024 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LFRic extension to vertical profile #638

LFRic extension to vertical profile #638

Sylviabohnenstengel commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

Sylviabohnenstengel commented May 23, 2024

jfrost-mo commented Jun 24, 2024

Sylviabohnenstengel commented Jun 25, 2024

Sylviabohnenstengel commented Jun 25, 2024

Sylviabohnenstengel commented Jun 25, 2024 •

edited

Loading

Sylviabohnenstengel commented Jun 25, 2024

Sylviabohnenstengel commented Jun 25, 2024

jfrost-mo commented Jun 25, 2024

jfrost-mo left a comment

Sylviabohnenstengel left a comment

jfrost-mo left a comment

LFRic extension to vertical profile #638

LFRic extension to vertical profile #638

Conversation

Sylviabohnenstengel commented May 23, 2024 • edited Loading

Contribution checklist

github-actions bot commented May 23, 2024 • edited Loading

Sylviabohnenstengel commented May 23, 2024

jfrost-mo commented Jun 24, 2024

Sylviabohnenstengel commented Jun 25, 2024

Sylviabohnenstengel commented Jun 25, 2024

Sylviabohnenstengel commented Jun 25, 2024 • edited Loading

Sylviabohnenstengel commented Jun 25, 2024

Sylviabohnenstengel commented Jun 25, 2024

jfrost-mo commented Jun 25, 2024

jfrost-mo left a comment

Choose a reason for hiding this comment

Sylviabohnenstengel left a comment

Choose a reason for hiding this comment

jfrost-mo left a comment

Choose a reason for hiding this comment

Sylviabohnenstengel commented May 23, 2024 •

edited

Loading

github-actions bot commented May 23, 2024 •

edited

Loading

Sylviabohnenstengel commented Jun 25, 2024 •

edited

Loading