Improve test coverage #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jfrost-mo
force-pushed
the
code-coverage-improvements
branch
from
5ad58f3
to
5819899
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Todo: Improve the way cubes are being compared in the write test, to make it deterministic and not randomly fail. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Use tempfile properly. It doesn't like it when we use a property of the object in a context manager.
Fixes ambiguity around passing a cubelist to a function that takes a cube. Also add some more comments. The aim here is to fix the random test failures.
Current syntax uses "|". "or" is not used. | is from 3.10 however, so we instead fall back to the older syntax: typing.Union[a, b]
We don't know that we are going to use these, and can easily recreate them if we do.
jfrost-mo
force-pushed
the
code-coverage-improvements
branch
from
e9d9970
to
d47ba0b
Compare
jwarner8
approved these changes
Mar 20, 2023
|
I've got it to 100% code coverage, but realistically that is going to drop a bit when we start adding lots of code. But it makes sense to at least start high. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are measuring test coverage, it makes sense to improve it.