-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic plotting capabilities #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
To Do:Add some other plot types. |
This prevents it from clashing with other workflows that also try to update the repository.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Previously it was being given an open file handle. Hopefully this will prevent the 30,000 line HDF5 crashdump.
Merged
jwarner8
reviewed
Apr 24, 2023
jwarner8
reviewed
Apr 24, 2023
jwarner8
reviewed
Apr 24, 2023
jwarner8
requested changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, few minor comments/edits before approving (also testing 'request change' option on GitHub!)
jwarner8
approved these changes
Apr 24, 2023
Thanks!
From: James W ***@***.***>
Sent: 24 April 2023 10:09
To: MetOffice/CSET ***@***.***>
Cc: James Frost ***@***.***>; Author ***@***.***>
Subject: Re: [MetOffice/CSET] Add basic plotting capabilities (PR #85)
This email was received from an external source. Always check sender details, links & attachments.
@jwarner8 approved this pull request.
—
Reply to this email directly, view it on GitHub<#85 (review)>, or unsubscribe[REDACTED].
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary operators to do a simple plotting workflow, where a variable is isolated and then visualised.
Specifically it adds a time constraint operator, and a spacial plot operator.
(And also a noop operator for testing)