Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic plotting capabilities #85

Merged
merged 15 commits into from
Apr 24, 2023
Merged

Add basic plotting capabilities #85

merged 15 commits into from
Apr 24, 2023

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Mar 24, 2023

This PR adds the necessary operators to do a simple plotting workflow, where a variable is isolated and then visualised.

Specifically it adds a time constraint operator, and a spacial plot operator.
(And also a noop operator for testing)

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@jfrost-mo
Copy link
Member Author

To Do:

Add some other plot types.
Consider how we are going to integrate them into workflows.

This prevents it from clashing with other workflows that also try to update
the repository.
@jfrost-mo jfrost-mo changed the title Add plotting capabilities Add basic plotting capabilities Apr 17, 2023
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

Coverage
Code coverage report

@jfrost-mo jfrost-mo marked this pull request as ready for review April 20, 2023 14:55
@jfrost-mo jfrost-mo requested a review from jwarner8 April 20, 2023 15:00
@jfrost-mo jfrost-mo mentioned this pull request Apr 21, 2023
tests/test_constraints.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, few minor comments/edits before approving (also testing 'request change' option on GitHub!)

@github-actions
Copy link
Contributor

Coverage
Code coverage report

@jfrost-mo jfrost-mo requested a review from jwarner8 April 24, 2023 08:58
@jfrost-mo
Copy link
Member Author

jfrost-mo commented Apr 24, 2023 via email

@jfrost-mo jfrost-mo merged commit 0b1cb64 into main Apr 24, 2023
5 checks passed
@jfrost-mo jfrost-mo deleted the add_plotting_capabilities branch April 24, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants