-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MPI compiler wrapper #312
Comments
I was imagining the decorator pattern. (not to be confused with Python decorators which are a bit different) In this approach the MPI class would accept a compiler to its constructor and would mutate inputs as they were passed through to that wrapped compiler. In this case it will always be called There is the issue of arguments but I believe that is handled by a different issue. |
Yes, I believe I mentioned decorator somewhere in the PR. Here how I have started (but as I've said, since there are quite a few functions to be passed through and therefore tested, I'll do this as a separate PR):
This is work in progress, so things might change. |
Also add Cray compiler. which are essentially compiler wrappers. |
An MPI compiler wrapper should be independent of the underlying compiler (but obviously use the compiler specific flags).
Best approach seems to be dynamically add mpi wrapper: if compiler
X
exist, create an MPI wrapperMpiX
, which takes anX
instance and use the X-specific flags.The ToolRepository or ToolBox should check to only add MPI wrapper for compiler that exist(?)
The text was updated successfully, but these errors were encountered: