Issue133 - accepting non string headers. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, back to the drawing board... noticed test_shim_copy_strip_slash failing... |
|
OK shim_copy_strip_slash is now fixed. should be ok. |
petersilva
requested review from
reidsunderland,
MagikEh,
tysonkaufmann and
andreleblanc11
andreleblanc11
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the original fix for sarrac not to crap out and reject messages when it receives messages
with headers that have non string values, that we still understand (adding known numeric ones.)
This should improve behaviour in the dynamic_flow, as, some such messages are present in the real flows from hpfx.collab.science.gc.ca