Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sender IO errors don't show paths #1098

Closed
reidsunderland opened this issue Jun 6, 2024 · 1 comment · Fixed by #1099
Closed

Sender IO errors don't show paths #1098

reidsunderland opened this issue Jun 6, 2024 · 1 comment · Fixed by #1099
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers regression Broke something that was working before.

Comments

@reidsunderland
Copy link
Member

reidsunderland commented Jun 6, 2024

We lost some useful information with this change (#1037). Now we only see which file failed to send, before we got a more generic error, but we saw the full path.

This is what we got before:

logger.error("Delivery failed %s" % msg['new_dir'] + '/' +
msg['new_file'])
logger.debug('Exception details: ', exc_info=True)

The new message doesn't include the path:

except Exception as ex:
logger.error( f"could not send inflight=None {new_file}: {ex}" )

Originally posted by @reidsunderland in #1037 (comment)

@reidsunderland reidsunderland added enhancement New feature or request good first issue Good for newcomers regression Broke something that was working before. labels Jun 6, 2024
@reidsunderland
Copy link
Member Author

I created an issue for this, because it was just a comment on a closed PR and I've been confused multiple times when trying to find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers regression Broke something that was working before.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants