Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sender io errors (download also...) #1037

Merged
merged 2 commits into from
May 6, 2024

Conversation

petersilva
Copy link
Contributor

Robbie asked for better error messages... yeah...

  • wrap all interactions with transfer protocols in try/except so instead of gettting stack traces we get a succinct summary:

I ran the flow tests and they pass.

Copy link

github-actions bot commented May 2, 2024

Test Results

209 tests   200 ✅  16s ⏱️
  1 suites    8 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit 5dfd33f.

@petersilva petersilva marked this pull request as ready for review May 3, 2024 13:06
@petersilva petersilva merged commit 6c743ee into development May 6, 2024
26 of 35 checks passed
@petersilva petersilva deleted the better_sender_IO_errors branch May 7, 2024 17:52
@reidsunderland
Copy link
Member

We lost some useful information with this change. Now we only see which file failed to send, before we got a more generic error, but we saw the full path.

This is what we got before:

logger.error("Delivery failed %s" % msg['new_dir'] + '/' +
msg['new_file'])
logger.debug('Exception details: ', exc_info=True)

The new message doesn't include the path:

except Exception as ex:
logger.error( f"could not send inflight=None {new_file}: {ex}" )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants