Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sr_http https://username@destination is used as is. #212

Open
michelgrenier opened this issue Jun 4, 2019 · 4 comments
Open

sr_http https://username@destination is used as is. #212

michelgrenier opened this issue Jun 4, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@michelgrenier
Copy link
Contributor

With the japan poll I came into this situation:

sr_poll posts messages with the username in the message.baseurl
when it is found in the credentials. It is a default behavior.
It needs to put the user since there can be many users
for the same server

The problem encountered is that sr_http tries to download the
file with username@ into the url ... and that did not worked

THE FIX ... in sr_http.py trim or rebuild the URL to use at download
make sure not to have username@ or username:password@

The easy way around for now was to use this option in sr_poll

post_base_url https://remoteserver

There is no case of many users on an https remote server for now.

@michelgrenier michelgrenier mentioned this issue Jun 13, 2019
@petersilva petersilva added the bug Something isn't working label Aug 17, 2019
@petersilva
Copy link
Contributor

Why is the user in the base_url at all? The user should affect how to authenticate... it doesn't add anything to the location. To me, the solution here is that post should not be posting with a username.

@michelgrenier
Copy link
Contributor Author

michelgrenier commented Sep 4, 2019 via email

@petersilva
Copy link
Contributor

I don't believe you on this one... but you are now a pumpkin, will need to discuss with others... see if anyone else understands.

@michelgrenier
Copy link
Contributor Author

michelgrenier commented Sep 8, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants