Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sr3 relative path on modified downloads, wrong reposts in some cases. #791

Closed
petersilva opened this issue Oct 23, 2023 · 1 comment · Fixed by #799
Closed

sr3 relative path on modified downloads, wrong reposts in some cases. #791

petersilva opened this issue Oct 23, 2023 · 1 comment · Fixed by #799
Assignees
Labels
bug Something isn't working Design Problem hard to fix, affects design. Priority 1 - ASAP Absolute Priority... really need to do this. v3only Only affects v3 branches. v3 issue deferred to or affects version 3

Comments

@petersilva
Copy link
Contributor

given subscriber settings like:

  • prefix v03
  • postBaseDir /A/B/C
  • directory /A/B/C/D/E
  • mirror off.

a file mine.txt obtained will be written to: /A/B/C/D/E/mine.txt

  • topic: v03, and a relPath of "mine.txt"

This is fine for downloading, as it gets it written to the right place (and topic does not matter) but incorrect when re-posting for subscribers. The correct values would be:

  • topic:v03.D.E relPath: D/E/mine.txt

Need to confirm that what the code does, and correct it. basically, mirror should affect download path, but the message should be correct relative to baseDir... not affected by relPath in download.

@petersilva
Copy link
Contributor Author

This isn't covered in test suites because whenever we have mirror off, it isn't reposted.

@petersilva petersilva changed the title sr3 relative path on modified downloads, wrong in some cases. sr3 relative path on modified downloads, wrong reposts in some cases. Oct 24, 2023
petersilva added a commit to MetPX/sr_insects that referenced this issue Oct 29, 2023
@petersilva petersilva added bug Something isn't working Design Problem hard to fix, affects design. Priority 1 - ASAP Absolute Priority... really need to do this. v3 issue deferred to or affects version 3 v3only Only affects v3 branches. labels Oct 29, 2023
@petersilva petersilva self-assigned this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Design Problem hard to fix, affects design. Priority 1 - ASAP Absolute Priority... really need to do this. v3only Only affects v3 branches. v3 issue deferred to or affects version 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant