Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.45 mirror off doesn't #796

Closed
petersilva opened this issue Oct 26, 2023 · 1 comment · Fixed by #799
Closed

v3.0.45 mirror off doesn't #796

petersilva opened this issue Oct 26, 2023 · 1 comment · Fixed by #799
Assignees
@petersilva
Labels
bug Something isn't working Priority 1 - ASAP Absolute Priority... really need to do this. regression Broke something that was working before.

Comments

@petersilva
Copy link
Contributor

the mirror setting is always on in v3.0.45.
@petersilva petersilva added bug Something isn't working regression Broke something that was working before. Priority 1 - ASAP Absolute Priority... really need to do this. labels Oct 26, 2023
@petersilva petersilva self-assigned this Oct 26, 2023
petersilva added a commit that referenced this issue Oct 26, 2023
@petersilva
main fix for #796 mirroring totally busted.
9dcf876
@petersilva
Copy link
Contributor Author

This is a regression unique to v3.0.45 caused by the fixes for #774. This episode demonstrates a huge gap in the CI/CD... there doesn't seem to be anything testing when mirror is off. Part of the work here is to add test cases to sr_insects so this does not slip through again.

petersilva added a commit that referenced this issue Oct 28, 2023
@petersilva
for file Operations (link,rename,mkdir,remove) in subscribers, separate
1478ae6 
the file op from the fileEvents, so that when fileEvents don't include
the operation, need to skip without falling through to file transfer.
working on #796
petersilva added a commit that referenced this issue Oct 28, 2023
@petersilva
for file Operations (link,rename,mkdir,remove) in sender, separate
f533c16 
the file op from the fileEvents, so that when fileEvents don't include
the operation, need to skip without falling through to file transfer.
working on #796
@petersilva petersilva mentioned this issue Oct 30, 2023
Merged
petersilva added a commit that referenced this issue Nov 2, 2023
@petersilva
main fix for #796 mirroring totally busted.
f708a43
petersilva added a commit that referenced this issue Nov 2, 2023
@petersilva
for file Operations (link,rename,mkdir,remove) in subscribers, separate
e52506a 
the file op from the fileEvents, so that when fileEvents don't include
the operation, need to skip without falling through to file transfer.
working on #796
petersilva added a commit that referenced this issue Nov 2, 2023
@petersilva
for file Operations (link,rename,mkdir,remove) in sender, separate
796d1d8 
the file op from the fileEvents, so that when fileEvents don't include
the operation, need to skip without falling through to file transfer.
working on #796
petersilva added a commit that referenced this issue Nov 6, 2023
@petersilva
main fix for #796 mirroring totally busted.
6ba871f
petersilva added a commit that referenced this issue Nov 6, 2023
@petersilva
for file Operations (link,rename,mkdir,remove) in subscribers, separate
ab43a40 
the file op from the fileEvents, so that when fileEvents don't include
the operation, need to skip without falling through to file transfer.
working on #796
petersilva added a commit that referenced this issue Nov 6, 2023
@petersilva
for file Operations (link,rename,mkdir,remove) in sender, separate
f561029 
the file op from the fileEvents, so that when fileEvents don't include
the operation, need to skip without falling through to file transfer.
working on #796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petersilva petersilva

Labels
bug Something isn't working Priority 1 - ASAP Absolute Priority... really need to do this. regression Broke something that was working before.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes for mirror off and relPath settings from it. MetPX/sarracenia
1 participant
@petersilva